-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contextfix #143
Contextfix #143
Conversation
i'll need some direction on how to proceed with this . |
I think version checks can go inside native_llvm_module. |
@gbaraldi, I'm curious if you have any comments on this PR. You wrote the original code here. |
@ArbitRandomUser sorry for the late reply, yeah you could do the version checks like in the link, but it looks like you could alternatively just use the JuliaContext() do ctx
# code using ctx here
end since |
tested on 1.8.0 and 1.9 on my machine. |
good to go ? or do we fix nightlies also ? |
Thanks @ArbitRandomUser! |
addressing #138
native_llvm_module for multiple functions now starts a context compiles and links the functions within the same context .