Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contextfix #143

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Contextfix #143

merged 5 commits into from
Oct 9, 2023

Conversation

ArbitRandomUser
Copy link
Contributor

addressing #138
native_llvm_module for multiple functions now starts a context compiles and links the functions within the same context .

@ArbitRandomUser
Copy link
Contributor Author

i'll need some direction on how to proceed with this .
Do i add the version dependent if statements from GPUCompiler.JuliaContext inside native_llvm_module ? , is that a good way to go about it ?

@tshort
Copy link
Owner

tshort commented Oct 7, 2023

I think version checks can go inside native_llvm_module.

@tshort
Copy link
Owner

tshort commented Oct 7, 2023

@gbaraldi, I'm curious if you have any comments on this PR. You wrote the original code here.

@MasonProtter
Copy link
Collaborator

@ArbitRandomUser sorry for the late reply, yeah you could do the version checks like in the link, but it looks like you could alternatively just use the JuliaContext function directly here, i.e.

JuliaContext() do ctx
    # code using ctx here
end

since JuliaContext appears to use the threadsafe context already.

@ArbitRandomUser
Copy link
Contributor Author

tested on 1.8.0 and 1.9 on my machine.

@ArbitRandomUser
Copy link
Contributor Author

good to go ? or do we fix nightlies also ?

@MasonProtter MasonProtter merged commit 1979264 into tshort:master Oct 9, 2023
9 of 12 checks passed
@MasonProtter
Copy link
Collaborator

Thanks @ArbitRandomUser!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants