Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-arg tMRCA #2808

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Multi-arg tMRCA #2808

merged 1 commit into from
Aug 5, 2023

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Jul 28, 2023

Fixes #2801 #2070 #2611

  • Tests that fully cover new/changed functionality.
  • Documentation including tutorial content if appropriate.
  • Changelogs, if there are API changes.

@jeromekelleher jeromekelleher added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Aug 3, 2023
@jeromekelleher
Copy link
Member

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 5, 2023

rebase

✅ Branch has been successfully rebased

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #2808 (d59f6d3) into main (71f3e3f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2808   +/-   ##
=======================================
  Coverage   89.97%   89.97%           
=======================================
  Files          30       30           
  Lines       29319    29322    +3     
  Branches     5706     5707    +1     
=======================================
+ Hits        26380    26383    +3     
  Misses       1669     1669           
  Partials     1270     1270           
Flag Coverage Δ
c-tests 86.49% <ø> (ø)
lwt-tests 80.78% <ø> (ø)
python-c-tests 67.81% <20.00%> (-0.02%) ⬇️
python-tests 99.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/tskit/trees.py 98.66% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f3e3f...d59f6d3. Read the comment docs.

@mergify mergify bot merged commit 11dd2f5 into tskit-dev:main Aug 5, 2023
21 checks passed
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree.tmrca error when MRCA does not exist
2 participants