Use more recent Sphinx #3022
Merged
Use more recent Sphinx #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 11 11
Lines 24666 24666
Branches 4556 4556
=======================================
Hits 21478 21478
Misses 1824 1824
Partials 1364 1364
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
For the docs CI we don't specify - the deps set it implicitly at 7.4.7, so yes this should be updated to that. |
benjeffery
approved these changes
Oct 16, 2024
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I seem to need this to get the docs compiling on my Mac laptop, which seems to require Sphinx >= 5. Is there any reason we pin to 4.5 specifically? 7.4.7 is the latest in the v7 series, and v8 is too bleeding edge to work smoothly.