MGMT-9451: Moving to new service-agent protocol #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving new commands : stop and logs Adding new step type for stop and logs
eranco74
reviewed
Mar 22, 2022
| // LogsGatherCmdRequest logs gather cmd request | ||
| // | ||
| // swagger:model logs_gather_cmd_request | ||
| type LogsGatherCmdRequest struct { |
There was a problem hiding this comment.
This is great, but how are you planning to deliver it? it seems that in order to do unmarshel in the agent side the agent will need to import this version of the service, I'm unsure you can deliver this change independently.
| package models | ||
|
|
||
| // This file was generated by the swagger tool. | ||
| // Editing this file might prove futile when you re-run the swagger generate command |
There was a problem hiding this comment.
Try rerunning without changing the swagger and ensure the validations aren't changed.
| return nil | ||
| } | ||
|
|
||
| func (m *LogsGatherCmdRequest) validateInsecure(formats strfmt.Registry) error { |
There was a problem hiding this comment.
Why do we need formats here?
| res = append(res, err) | ||
| } | ||
|
|
||
| if len(res) > 0 { |
There was a problem hiding this comment.
If all validations pass res will be [nil, nil, nil, nil...], no ?
|
|
||
| func (m *LogsGatherCmdRequest) validateInsecure(formats strfmt.Registry) error { | ||
|
|
||
| if err := validate.Required("insecure", "body", m.Insecure); err != nil { |
There was a problem hiding this comment.
What are you validating here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving new commands : stop and logs
Adding new step type for stop and logs
Assisted Pull Request
Description
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Assignees
/cc @
/cc @
Checklist
docs, README, etc)Reviewers Checklist