Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No public decks #238

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

thyhellcat
Copy link
Contributor

No description provided.

@Timtam
Copy link
Collaborator

Timtam commented Jun 18, 2020

I don't like the way the "problem" is solved here. I like the idea of splitting the public and non-public deck view into multiple commands, but we're a mud for all kinds of players here, not only the programmer-oriented ones, and an argument like -n is deffinitely not HCI-friendly. I'd suggest a second command, like let the deck command only show your decks and add a second command publicdecks or something like that which only shows the public decks.
@tspivey what do you think?

@tspivey
Copy link
Owner

tspivey commented Jun 18, 2020

I think the default view should be your decks, maybe with deck publiclist showing the public decks, like in the lobby.

@thyhellcat
Copy link
Contributor Author

The problem here is that beginners wouldn't pay attention to all available commands. That happens so often. Maybe -n isn't user-friendly, but at least we're likely to avoid people calling their deck '-n'. And those who don't want to see public decks probably are interested in the game enough to check available commands. We can change it to something different than '-n', obviously, but I thought it was quick and easy.

…want to be spammed by 150 public decks before seeing their own list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants