feat: Validate app processes are alphabetically sorted #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crgisch
reviewed
Jan 13, 2025
| @@ -230,6 +230,10 @@ func resourceTsuruApplicationCreate(ctx context.Context, d *schema.ResourceData, | |||
| if m, ok := d.GetOk("process"); ok { | |||
| processes := processesFromResourceData(m) | |||
| if processes != nil { | |||
| err := isProcessListSorted(processes) | |||
There was a problem hiding this comment.
The name isProcessListSorted makes me believe this returns true or false, but thats not the case here.
Mais something like sortProcessesList could work better here? What do you think?
There was a problem hiding this comment.
You're absolutely right—isProcessListSorted suggests a boolean return, which no longer reflects this function behavior after the recent changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature introduces a validation to ensure that app processes are defined in alphabetical order. Improving consistency and predictability when managing apps via Terraform.
changes: