Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): resolve home graph issues #124

Merged

Conversation

tsutsu3
Copy link
Owner

@tsutsu3 tsutsu3 commented Feb 1, 2025

  • queries
    • legend
    • axis

graph3

  • clients
    • legend
    • axis

graph4

@tsutsu3 tsutsu3 linked an issue Feb 1, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.49%. Comparing base (b305ab8) to head (46b2af8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../screens/home/widgets/queries_last_hours_line.dart 48.38% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   67.49%   67.49%   -0.01%     
==========================================
  Files         126      127       +1     
  Lines        7718     7730      +12     
==========================================
+ Hits         5209     5217       +8     
- Misses       2509     2513       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Feb 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
55.6% Coverage on New Code (required ≥ 80%)
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@tsutsu3 tsutsu3 merged commit 9e13d66 into main Feb 1, 2025
9 of 12 checks passed
@tsutsu3 tsutsu3 deleted the 123-graph-axis-display-issue-duplicate-or-overlapping-ticks branch February 1, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph Axis Display Issue: Duplicate or Overlapping Ticks
1 participant