feature: support dumping jobs to disk. #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shils
reviewed
Feb 1, 2020
| * @param {Object} [filter={}] The sift-compatible filter | ||
| */ | ||
| async dump(jobType, filter = {}) { | ||
| const matches = await this._find(jobType, filter); |
There was a problem hiding this comment.
I think it'd make sense to add a forEach method so that we could write the jobs out without needing to have them all in memory.
There was a problem hiding this comment.
Agreed, there could be a ton of jobs here - so paginating would be ideal. It might make sense to add a batch processor to handle matches as we find them here.
ttacon
requested changes
Feb 2, 2020
| @@ -7,6 +7,9 @@ const redis = require('redis'); | |||
| const repl = require('repl'); | |||
| const sift = require('sift').default; | |||
| const getValue = require('get-value'); | |||
| const waitOn = require('promise-callbacks').waitOn; | |||
There was a problem hiding this comment.
Suggested change
| const waitOn = require('promise-callbacks').waitOn; | |
| const { waitOn } = require('promise-callbacks'); |
| * @param {Object} [filter={}] The sift-compatible filter | ||
| */ | ||
| async dump(jobType, filter = {}) { | ||
| const matches = await this._find(jobType, filter); |
There was a problem hiding this comment.
Agreed, there could be a ton of jobs here - so paginating would be ideal. It might make sense to add a batch processor to handle matches as we find them here.
shils
reviewed
Feb 2, 2020
| await waitOn(jsonWriteStream, 'finish', { waitError: true }); | ||
| console.log(`Dumped ${cleanedMatches.length} jobs to ${filename}`); | ||
| } catch (err) { | ||
| console.error('Failed to write to fail', err); |
There was a problem hiding this comment.
Suggested change
| console.error('Failed to write to fail', err); | |
| console.error('Failed to write to file', err); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2