Feature: Define storage node by identifier #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of defining the siteNode path and the storage node path, in case the storage node already exists, you can use the indetifier of the storage node. See issue ttreeagency#24
daniellienert
commented
Aug 25, 2017
| throw new Exception(sprintf('The storage node with identifier "%s" was not found', $this->storageNodeIdentifier)); | ||
| } | ||
|
|
||
| $pathParts = explode('/', ltrim($this->storageNode->getPath(), '/')); |
There was a problem hiding this comment.
@dfeyer: This part is quite hacky - is there a better solution?
|
You can set the storageNodeNodePath to #a6436b8a-de68-4f79-9689-8ec7ff021b54 to set it by identifier, so I think this PR is not needed But I agree that storageNodeNodePath can be renamed ;) but it's breaking or need a BC layer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of defining the siteNode path and the storage node path,
in case the storage node already exists, you can use the
indetifier of the storage node.
See issue #24