You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that when creating the minibatchlist (main.py#L121), the wrong total number of element is used (because all last observation of each episode is removed):
In fact, the current code always works when we have num_episodes < batchsize, but breaks when we have a lot of episodes ( num_episodes > 2 * batchsize).
Hello,
It seems that when creating the minibatchlist (main.py#L121), the wrong total number of element is used (because all last observation of each episode is removed):
indices
has not a length ofnum_samples
, so instead ofnum_samples - self.batchsize + 1
, it should belen(indices) - self.batchsize + 1
:In fact, the current code always works when we have
num_episodes < batchsize
, but breaks when we have a lot of episodes (num_episodes > 2 * batchsize
).this bug was spotted by @Elovir and @hill-a
The text was updated successfully, but these errors were encountered: