Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LogginCard #50

Merged
merged 3 commits into from
Nov 5, 2024
Merged

feat: add LogginCard #50

merged 3 commits into from
Nov 5, 2024

Conversation

thisagi
Copy link
Contributor

@thisagi thisagi commented Nov 5, 2024

SSIA

Copy link

cloudflare-workers-and-pages bot commented Nov 5, 2024

Deploying school-festival-2024 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 53e69b3
Status: ✅  Deploy successful!
Preview URL: https://0c9b2aa9.school-festival-2024.pages.dev
Branch Preview URL: https://loggin-card.school-festival-2024.pages.dev

View logs

@thisagi thisagi requested a review from shun-shobon November 5, 2024 08:50
className,
)}
>
<h1 className={cn(className)}>名前を入力して登録!</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1 className={cn(className)}>名前を入力して登録!</h1>
<h1 className="text-2xl drop-shadow-base">名前を入力して登録!</h1>

return (
<Card
className={cn(
"flex flex-col items-center gap-y-4 p-4 text-[24px]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"flex flex-col items-center gap-y-4 p-4 text-[24px]",
"flex flex-col items-center gap-y-4 p-4",

)}
>
<h1 className={cn(className)}>名前を入力して登録!</h1>
<Input placeholder="名前" className={cn("text-[16px]", className)} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Input placeholder="名前" className={cn("text-[16px]", className)} />
<Input placeholder="名前" />

>
<h1 className={cn(className)}>名前を入力して登録!</h1>
<Input placeholder="名前" className={cn("text-[16px]", className)} />
<Button type="submit" className={cn("text-[16px]", className)}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Button type="submit" className={cn("text-[16px]", className)}>
<Button type="submit">

@thisagi thisagi requested a review from shun-shobon November 5, 2024 09:08
@thisagi thisagi merged commit 95c44fc into main Nov 5, 2024
4 checks passed
@thisagi thisagi deleted the loggin-card branch November 5, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants