-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Continuous Integration (CI) using GitHub actions #203
Conversation
…ull request. Cache the conda environment to speed up the build across subsequent runs. Data files in tudat-resources are not cached. They are downloaded separately in an event of a cache hit. Failing tests in MacOS are temporarily ignored to let the workflow pass and the cache feature to be tested.
ccache works out of the box for the GNU compilers in Ubuntu and the Clang compiler in MacOS. The MSVC compilers require an extra configuration step which was added to the CMakeLists file.
Feature/add ccache
Rename the ccache step to describe what it does. Fix typo in referencing the matrix variable build type.
…se proceeds with the build step. Caching of compilation results of the current run happens post completion of the build step.
…o a feature branch that is also a source in a pull request
- name: Build | ||
# Build your program with the given configuration. Note that --config is needed because the default Windows generator is a multi-config generator (Visual Studio generator). Use multiple cpu cores available in the runner. | ||
shell: bash -l {0} | ||
run: cmake --build "${{ github.workspace }}/build" --config "${{ matrix.build_type }}" -j4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this would cause any problems but according to this: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories macos-latest
only has 3 cores available if I understand correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch @LeonardoPohl :) ! We had a look and it appears the Apple M1s have 8 cores each. The macos-latest runner has 3 M1 processors, thus giving us a total of 24 cores.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok great, good to know thanks :)
Thanks! This looks awesome :) I'm merging this now, and will test it out soon! |
Summary of code changes
Results