Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BL-1171: Update blacklight_range_limit. #1944

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

dkinzer
Copy link
Member

@dkinzer dkinzer commented Jun 23, 2020

Does not override the range limit view because we would need to override the entire view and thus lose possible upgrade changes.

New version:
image

Old version:
image

@dkinzer dkinzer requested review from amecynth and ebtoner June 23, 2020 21:24
@dkinzer dkinzer force-pushed the bl-1171-update-blacklight-range-limit branch from 4e2c96f to 83a5cea Compare June 23, 2020 23:49
@amecynth
Copy link

David Kinzer, I'm looking at the new date slider on QA. I am OK with the slider being on the top instead of the bottom of the date range. I narrowed my date range once and the layout was fine. But then I narrowed it for a second time and the height of the date range tripled.
Screen Shot 2020-06-24 at 8 30 47 AM

* Updates blacklight_range_limit to latest version.
* Patches JS issue.
* Hides remove button (to keep current behavior)
* Patches render_constraints_filters method (projectblacklight/blacklight_range_limit#152)
@dkinzer dkinzer force-pushed the bl-1171-update-blacklight-range-limit branch from 83a5cea to 9fc4629 Compare June 24, 2020 13:28
@dkinzer dkinzer requested review from bibliotechy and quoideneuf and removed request for amecynth and ebtoner June 24, 2020 13:32
@dkinzer
Copy link
Member Author

dkinzer commented Jun 24, 2020

@amecynth thanks for reporting. I believe @ebtoner has mentioned this issue in the past to me but it's hard to reproduce consistently.

Note however I have a patch for that issue in this PR which should do away with it. But it has not yet bee merged and not ready to qa/testing just yet.

@dkinzer dkinzer marked this pull request as ready for review June 24, 2020 13:40
@amecynth
Copy link

Ok, thanks! In the scope of all the work that needs to be done, this making this display completely perfect is a lower priority, so I would say it looks good and go ahead and implement whatever patch you have.

@quoideneuf quoideneuf merged commit ce54cea into master Jun 24, 2020
@dkinzer dkinzer deleted the bl-1171-update-blacklight-range-limit branch July 30, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants