Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-wildcard imports in mappersmith gateway #564

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

riyadhalnur
Copy link

  • Switch to using default imports for libraries imported in gateway
  • Default imports (import http) create a direct reference to the module exports
  • Named imports and namespace imports (import * as) create a new reference that won't reflect patches

We have a use case where we patch methods exposed by node:http and node:https globally in a node.js application. This affects applications compiled using ESM. CJS application are unaffected. Tested this change and this doesn't affect any existing applications using mappersmith.

Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: dd6bcc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant