[wip] web/timeline: use tanstack virtual to virtualise timeline #581
+193
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
reviewed
Jan 2, 2025
web/src/ui/timeline/TimelineView.tsx
Outdated
| } | ||
| }, [ | ||
| room.hasMoreHistory, loadHistory, | ||
| virtualizer.getVirtualItems(), |
There was a problem hiding this comment.
This effect is now ran on every render because loadHistory changes every time (useCallbacks are not there just for fun). Eslint is also complaining about missing dependencies
There was a problem hiding this comment.
This seems to be run on every render anyway due to virtualizer.getVirtualItems(). Not sure what to do about this, as it's the suggested way to achieve this effect in https://tanstack.com/virtual/latest/docs/framework/react/examples/infinite-scroll, and from what I can see, the actual result of firstItem doesn't change.
JadedBlueEyes
force-pushed
the
jade/tanstack-virtual
branch
from
5decae0 to
7616a55
Compare
JadedBlueEyes
force-pushed
the
jade/tanstack-virtual
branch
from
7616a55 to
1e339d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work pretty well so far
todo:
shouldAdjustScrollPositionOnItemSizeChangeto fix some scroll jumpslower priority:
timeline(shifting indexes / pretending to array)