Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add requested at in group participants request #733

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

AlejandroPerez92
Copy link
Contributor

Return new Struct in GetGroupRequestParticipants

Summary

This pull request introduces a new struct for wrap the response of the method GetGroupRequestParticipants(), that was made because i needed to get the date when the request was sent along with the JID.

Changes

  • Added new GroupParticipantRequest
  • Changed the return type of GetGroupRequestParticipants from JID to the new struct
  • Parsed the filed request_time from the request to the new response struct

That change will introduce a braking change

group.go Outdated Show resolved Hide resolved
Copy link

@devlikepro devlikepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change will introduce a braking change

This should be fine in a statically and strongly typed language like Go. :)

@AlejandroPerez92
Copy link
Contributor Author

@devlikepro I can't merge it At least 1 approving review is required by reviewers with write access.

Regarding the breaking change, in that case, can we rely on semantic versioning?

@devlikepro
Copy link

Sorry, I was just passing by here, I have no rights just as you 🤣
I'm also waiting for @tulir in other PR when he has time :)

@tulir tulir merged commit c3c6a06 into tulir:main Jan 31, 2025
2 checks passed
crazycodezombie pushed a commit to crazycodezombie/whatsmeow that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants