Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Thingsboard into Pyra #226

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

patrickjaigner
Copy link
Contributor

Feature Description #225

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for pyra-4-documentation canceled.

Name Link
🔨 Latest commit 51cad26
🔍 Latest deploy log https://app.netlify.com/sites/pyra-4-documentation/deploys/6696458abc000d0008cb37bc

Copy link
Member

@dostuffthatmatters dostuffthatmatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I already review this?

Please make sure to format your code using YAPF and that the formatter uses the configuration parameters inside the pyproject.toml.

@patrickjaigner
Copy link
Contributor Author

@dostuffthatmatters I will ping you when it is ready to review. If you like, you can quickly check the structural integration to avoid later issues.

@patrickjaigner
Copy link
Contributor Author

@dostuffthatmatters You check the changes now. I tested the client integration and an example payload publish on my machine.

@patrickjaigner patrickjaigner self-assigned this Jul 15, 2024
Copy link
Member

@dostuffthatmatters dostuffthatmatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good until now! very simpel TB thread code.

Please format your code using YAPF with the settings specified in the pyproject.toml file.

package-lock.json Outdated Show resolved Hide resolved
packages/core/threads/thingsboard_thread.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
packages/core/threads/thingsboard_thread.py Show resolved Hide resolved
packages/core/threads/thingsboard_thread.py Outdated Show resolved Hide resolved
packages/core/main.py Outdated Show resolved Hide resolved
@patrickjaigner patrickjaigner marked this pull request as ready for review July 15, 2024 16:05
@patrickjaigner
Copy link
Contributor Author

@dostuffthatmatters I implemented the changes.

Copy link
Member

@dostuffthatmatters dostuffthatmatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Way cleaner now. Only a few changes required.

packages/core/threads/thingsboard_thread.py Outdated Show resolved Hide resolved
packages/core/threads/thingsboard_thread.py Show resolved Hide resolved
packages/core/types/config.py Show resolved Hide resolved
tests/repository/test_default_config.py Show resolved Hide resolved
Copy link
Member

@dostuffthatmatters dostuffthatmatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Only missing the UI.

@patrickjaigner
Copy link
Contributor Author

@dostuffthatmatters thank you for the helpful feedback. Would you mind taking over the UI part? I checked the files in packages/ui/src/components/configuration/sections and have no idea about this kind of stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants