-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Thingsboard into Pyra #226
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for pyra-4-documentation canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I already review this?
Please make sure to format your code using YAPF and that the formatter uses the configuration parameters inside the pyproject.toml
.
@dostuffthatmatters I will ping you when it is ready to review. If you like, you can quickly check the structural integration to avoid later issues. |
@dostuffthatmatters You check the changes now. I tested the client integration and an example payload publish on my machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good until now! very simpel TB thread code.
Please format your code using YAPF with the settings specified in the pyproject.toml
file.
@dostuffthatmatters I implemented the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Way cleaner now. Only a few changes required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Only missing the UI.
@dostuffthatmatters thank you for the helpful feedback. Would you mind taking over the UI part? I checked the files in packages/ui/src/components/configuration/sections and have no idea about this kind of stuff. |
Feature Description #225