Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Exponax Release #10

Merged
merged 11 commits into from
Oct 23, 2024
Merged

Forward Exponax Release #10

merged 11 commits into from
Oct 23, 2024

Conversation

Ceyron
Copy link
Collaborator

@Ceyron Ceyron commented Oct 23, 2024

Updates to Exponax 0.1.0 and forward all API changes.

Since Exponax changed some internals, this can affect some benchmarks. The most important changes are:

  1. Change in the metric system (normalized metrics now normalized per channel and not over all channels)
  2. Convection Nonlinearity changed to a non-conservative form by default ($b_1 \frac{1}{2} \nabla \cdot (u \otimes u) \rightarrow b_1 (u \cdot \nabla) u$), but the old "conservative" version is still available. I decided to keep it as the default in APEBench via setting the conservative=True for all steppers using convection. This is to ensure legacy compatibility
  3. For efficiency, Substeppers now operate in Fourier space. Qualitatively, this should not alter produced trajectories but can cause numeric differences, especially for chaotic problems (KS, etc.). This can slightly alter benchmark runs numeric results. To avoid the influence of the concrete dataset, consider rerunning benchmark runs with different train and test seeds.

@Ceyron Ceyron merged commit 6167047 into main Oct 23, 2024
7 checks passed
@Ceyron Ceyron deleted the forward-exponax-release branch October 23, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant