Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #82, which turned out to be more complicated than I expected. Here are the changes:
org.scribe
tocom.github.scribejava
, the version was updated from1.3.3
to2.0.1
async-http-client
. Either gson or scribe needs this, and for some reason neither of them includes it.Response.getCode()
is nowfinal
, so it is no longer possible to mock it with Mockito (see model.Request, Reponse objects don't play well with unit test mocking frameworks scribejava/scribejava#313). Luckily, onlyprivate
methods were being tested, so the solution was to add a helper method that took acode
as an additional argument, and thenRequestBuilderTest
would test that method instead.openjdk6
because scribejava targets Java 7 and up: https://github.com/scribejava/scribejava/blob/master/pom.xml#L111-L112