Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] UT "sectional-solid-horizontal" #468

Draft
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

Elvira2227
Copy link
Collaborator

@Elvira2227 Elvira2227 commented Aug 22, 2021

Added new unit test "sectional-solid-horizontal" to check #463. Fixes #463 .

Redid analysis as in this issue in usBIM.viewer (on the left side of the screenshot) and OIP (on the right).
image

The former does not read the deck and railings.
OIP reads all the parts, but with wrong orientations and the rails are in incorrect shape.

Work in progress

@Elvira2227 Elvira2227 added bug Something isn't working example-files Issue related to failing reading an example file IFC Content related to Industry Foundation Classes (IFC) functionalities labels Aug 22, 2021
@Elvira2227 Elvira2227 self-assigned this Aug 22, 2021
@pjanck pjanck marked this pull request as draft August 23, 2021 06:03
@pjanck
Copy link
Contributor

pjanck commented Aug 23, 2021

This definitely looks interesting. I see multiple separate issues that can be addressed:

  • handling of I profiles: it seems that the code disregards the bottom/top flange inner point - I assume only a single point is somehow missing
  • orientation of beams and deck vs the alignment: are there IfcLinearPlacement and/or IfcAxis2PlacementLinear in the file? If yes - we don't support these yet (fully).
  • can you post a screen shot of the whole model from top left?

Note: to screen shot just the active window, use Alt + PrtSc, see https://www.digitalcitizen.life/screenshot-windows/

Copy link
Contributor

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the file is 4x1, so there can be no IfcAxis2PlacementLinear - disregard that comment.

Check for existence of IfcSectionedSolidHorizontal in the unit test code.

@Elvira2227
Copy link
Collaborator Author

  • Screen shot of the top left:

image

  • Screen shot of the top left front:

image

  • IfcSectionedSolidHorizontal exist in the unit test code

Copy link
Collaborator

@jschlenger jschlenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did we conclude here? Were there mistakes in the Ifc file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working example-files Issue related to failing reading an example file IFC Content related to Industry Foundation Classes (IFC) functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] Additional example
3 participants