Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IFC4X3 #571

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

Update IFC4X3 #571

wants to merge 5 commits into from

Conversation

Elvira2227
Copy link
Collaborator

@Elvira2227 Elvira2227 commented Nov 4, 2022 •
edited
Loading

This pull request contains final schema for IFC4X3.
Please find differences between _RC4 here.

Several changes correspond to the CurveConverter. Here I added some if define statements.

We need also to update implementation for the IfcSectionedSolidHorizontal #570.

@Elvira2227 Elvira2227 added IFC Content related to Industry Foundation Classes (IFC) functionalities early-binding-generator Related to early binding generation labels Nov 4, 2022
@Elvira2227 Elvira2227 mentioned this pull request Nov 4, 2022
Open
@Elvira2227 Elvira2227 self-assigned this Nov 4, 2022
@jschlenger
Copy link
Collaborator

jschlenger commented Nov 10, 2022 •
edited
Loading

Maybe it could make sense to take the list of differences between IFC4x3_RC4 and IFC4x3 and make an internal list that just contains the information about the part that is relevant for us. That would help us to then also put check marks for the ones that we already resolved.
Let's talk about this in the meeting today.

jschlenger
jschlenger reviewed Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@jschlenger jschlenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Does it already compile?
I really think a table with changes relevant to OIP makes sense here.
Then we could, e.g. already tick of that the name changes of sine and cosine was taken care of.

@Elvira2227
Copy link
Collaborator Author

In the last commit 7076b77 I listed relevant changes for OIP.

jschlenger
jschlenger reviewed Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@jschlenger jschlenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.
There are a couple of entities missing that could also be relevant for us.

@Elvira2227 Elvira2227 requested a review from jschlenger December 2, 2022 13:13
jschlenger
jschlenger reviewed Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@jschlenger jschlenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

pjanck
pjanck reviewed Jan 21, 2023
View reviewed changes
Copy link
Contributor

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, the changes are in all correct places. Does it compile though? In both 4x3 and 4x3rc4?

Core/src/IfcGeometryConverter/SolidModelConverter.h
bool fixedAxisVertical = sectionedSolidHorizontal->FixedAxisVertical;

#else
bool fixedAxisVertical = true;//please rewrite it!! wrong implementation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please denote this as Todo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjanck pjanck pjanck left review comments

@jschlenger jschlenger jschlenger left review comments

Assignees

@Elvira2227 Elvira2227

Labels
early-binding-generator Related to early binding generation IFC Content related to Industry Foundation Classes (IFC) functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elvira2227 @jschlenger @pjanck