Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gosec - G115 #519

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Gosec - G115 #519

wants to merge 4 commits into from

Conversation

Pro7ech
Copy link
Collaborator

@Pro7ech Pro7ech commented Nov 28, 2024 •
edited
Loading

  • Reviewed all G115 flagging
  • Re-enabled G115 rule
  • Added a checks with panic for a few functions where the user could input invalid values that can trigger integer overflow during conversion

@Pro7ech Pro7ech self-assigned this Nov 28, 2024
lehugueni
lehugueni reviewed Dec 12, 2024
View reviewed changes
circuits/bgv/polynomial/polynomial_evaluator_sim.go Outdated Show resolved Hide resolved
circuits/ckks/polynomial/polynomial_evaluator_sim.go Outdated Show resolved Hide resolved
circuits/common/polynomial/power_basis.go Outdated Show resolved Hide resolved
core/rlwe/element.go Outdated Show resolved Hide resolved
core/rgsw/blindrot/evaluator.go Outdated Show resolved Hide resolved
ring/subring.go Outdated Show resolved Hide resolved
schemes/ckks/ckks_vector_ops.go Outdated Show resolved Hide resolved
utils/structs/map.go Outdated Show resolved Hide resolved
utils/structs/map.go Outdated Show resolved Hide resolved
utils/structs/map.go Outdated Show resolved Hide resolved
romainbou
romainbou reviewed Dec 19, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
romainbou
romainbou approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@romainbou romainbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lehugueni
lehugueni approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@lehugueni lehugueni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lehugueni
Copy link
Contributor

@Pro7ech: can you merge the last changes into this branch? That should make the workflows run on this PR.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainbou romainbou romainbou approved these changes

@lehugueni lehugueni lehugueni approved these changes

Assignees

@Pro7ech Pro7ech

Labels
Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pro7ech @lehugueni @romainbou