Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add Go v1.23 to the matrix of tests #536

Merged
merged 4 commits into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
name: CI Checks
on:
push:
pull_request:
workflow_dispatch:
jobs:
checks:
name: Run static checks
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 1
- name: Setup Go
uses: actions/setup-go@v4
uses: actions/setup-go@v5
with:
go-version: '1.22.2'
go-version: '1.23.5'

- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-tools-${{ hashFiles('**/go.sum') }}
Expand All @@ -32,17 +34,17 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go: ['1.22.2', '1.21.9']
go: ['1.23.5', '1.22.11', '1.21.13']

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup Go
uses: actions/setup-go@v4
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go }}

- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: |
~/.cache/go-build
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ checks: check_tools
false;\
fi

@STATICCHECKOUT=$$(staticcheck -go 1.22 -checks all ./...); \
@STATICCHECKOUT=$$(staticcheck -go 1.23 -checks all ./...); \
if [ -z "$$STATICCHECKOUT" ]; then\
echo "staticcheck: OK";\
else \
Expand Down Expand Up @@ -78,7 +78,7 @@ EXECUTABLES = goimports staticcheck govulncheck gosec
.PHONY: get_tools
get_tools:
go install golang.org/x/tools/cmd/goimports@latest
go install honnef.co/go/tools/cmd/staticcheck@2023.1.7
go install honnef.co/go/tools/cmd/staticcheck@2024.1.1
go install golang.org/x/vuln/cmd/govulncheck@latest
go install github.com/securego/gosec/v2/cmd/gosec@latest

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ Lattigo package organization is given in the Figure above.
subpackage includes test files that further demonstrate the use of Lattigo
primitives.

- `lattigo/utils`: Generic utility methods. This package also contains the following sub-pacakges:
- `lattigo/utils`: Generic utility methods. This package also contains the following sub-packages:
- `bignum`: Arbitrary precision linear algebra and polynomial approximation.
- `buffer`: Efficient methods to write/read on `io.Writer` and `io.Reader`.
- `factorization`: Various factorization algorithms for medium-sized integers.
Expand Down
Loading