Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validator_delegations query #249

Merged

Conversation

freak12techno
Copy link
Contributor

No description provided.

@keppel
Copy link
Contributor

keppel commented Jan 18, 2024

Looking good, but since this query can be pretty expensive for a validator with a lot of delegators, in the future we'll want to support pagination here.

Options include:

  • Pagination for just this query (would need to provide a limit and a start_key since an integer offset wouldn't make sense in the underlying map).
  • More general support for query pagination (eg. a store error after some number of reads on the resolving node triggering the partial response)
  • A feature flag for enabling expensive queries for use cases where you're only querying a local node.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (11701c3) 58.89% compared to head (f0bcb96) 58.85%.
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #249      +/-   ##
===========================================
- Coverage    58.89%   58.85%   -0.04%     
===========================================
  Files           84       84              
  Lines        15744    15748       +4     
===========================================
- Hits          9272     9269       -3     
- Misses        6472     6479       +7     
Files Coverage Δ
src/coins/staking/mod.rs 61.94% <0.00%> (-0.38%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

@keppel keppel added this pull request to the merge queue Jan 26, 2024
Merged via the queue into turbofish-org:develop with commit 38682a1 Jan 27, 2024
7 checks passed
@freak12techno freak12techno deleted the add-validator-delegations-query branch January 27, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants