feat: allow connecting to insecure OpenTelemetry endpoints with STEAMPIPE_OTEL_INSECURE environment variable #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdecat
force-pushed
the
feat/allow_insecure_otel
branch
from
00778f8 to
efd2642
Compare
|
Without this change, trying to use a local insecure OpenTelemetry server triggers this error message: |
|
@pdecat please could you kick off the tests again and rebase if needed, let's try to merge this finally |
…PIPE_OTEL_INSECURE environment variable Especially useful when connecting to a local OpenTelemetry ingesting server
pdecat
force-pushed
the
feat/allow_insecure_otel
branch
from
efd2642 to
12ac152
Compare
|
Rebased, and chaos acceptance tests are still failing. |
pskrbasu
approved these changes
Feb 8, 2024
|
We sincerely apologize for the oversight, @pdecat. Unfortunately, this PR slipped our attention. |
|
Hi @pskrbasu, no problem :) Thanks! |
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially useful when connecting to a local OpenTelemetry ingesting server