Feature/lazyness #229
Open
Feature/lazyness #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think the attribute .is_lazy for the plugins is not exactly what it means, it means it can be lazy. If i'm wrong, please explain this to me @turicas
I'm saying this because I don't think lazy tables should be default for rows since it depends on the use cases.
| @@ -25,6 +25,39 @@ | |||
| from rows.fields import identify_type | |||
|
|
|||
|
|
|||
| class LazyTable(object): | |||
There was a problem hiding this comment.
Isn't it a good idea to create a BaseTable class to all *Table classes to inherit from?
|
Add some documentation with your explanation for the questions above. |
turicas
force-pushed
the
feature/lazyness
branch
from
c65aee3 to
5c6da04
Compare
turicas
force-pushed
the
feature/lazyness
branch
from
5c6da04 to
56aea5a
Compare
|
Using the babel library would help us solving some problems the locale library from stdlib has. |
turicas
force-pushed
the
feature/lazyness
branch
from
56aea5a to
ac33e7f
Compare
turicas
force-pushed
the
develop
branch
2 times, most recently
from
fa144f0 to
bbb2c57
Compare
turicas
force-pushed
the
feature/lazyness
branch
from
ac33e7f to
9d2504a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #45