Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vcr #131

Open
wants to merge 136 commits into
base: main
Choose a base branch
from
Open

Vcr #131

wants to merge 136 commits into from

Conversation

JoannaCoPo
Copy link

No description provided.

Caleb1991 and others added 30 commits July 5, 2021 16:54
@Caleb1991
Create pull_request_template.md
3de11a6 
Created pull request template.

Co-authored-by: Joanna Cortes [email protected]
@JoannaCoPo
Merge pull request #20 from Caleb1991/Caleb1991-patch-1
7bcf0b2 
Create pull_request_template.md
@Caleb1991
Add rubocop to gemfile
d43d46d
@Caleb1991
Delete gemfile.lock
5f0a693
@Caleb1991
bundle install
683b22e
@Caleb1991
Update Travid yml file
a7a79d4
@JoannaCoPo
Merge pull request #22 from Caleb1991/gemfile_update_2
bd151d7 
Gemfile update 2
@JoannaCoPo
Add schema diagram
0280a59
@JoannaCoPo
Fix file path
3c70f47
@JoannaCoPo
Fix file path
fcbc63e
@JoannaCoPo
Update README.md
73e6a78
@JoannaCoPo
Update README.md
667cbac
@Caleb1991
Merge pull request #23 from Caleb1991/schema
0075cfe 
Schema
@Caleb1991
Create user table
0aa0447
@JoannaCoPo
Merge pull request #24 from Caleb1991/registration_page
cbce4b0 
Create user table
@JoannaCoPo
Change ruby v to 2.7.2
fd633c3
@JoannaCoPo
TDD welcome page
8acec1c
@JoannaCoPo
Add route for welcome index
c98ba4b
@JoannaCoPo
Create welcome controller
d5e9751
@JoannaCoPo
Add shoulda matchers
438d857
@JoannaCoPo
Add model test for user
32a8176
@JoannaCoPo
Add validations and has_secure_password to User
ae7d4cd
@JoannaCoPo
Add view functionality
b7eb363
@Caleb1991
Create functionality for registration page, and test for edge cases o…
ce21baa 
…f email uniqueness and password confirmation
@Caleb1991
Correct Rubocop warnings
d6e7bab
@JoannaCoPo
Merge pull request #25 from Caleb1991/registration_form
18a47f4 
Create functionality for registration page, and test for edge cases o…
@Caleb1991
Create migrations for User Friendships, Viewing Parties, and Attendees
1c78556
@JoannaCoPo
Merge pull request #26 from Caleb1991/migrations
95fbfaf 
Create migrations for User Friendships, Viewing Parties, and Attendees
@JoannaCoPo
Save work
d6b78b6
@JoannaCoPo
Define current_user helper in application controller
1d7ce00
JoannaCoPo and others added 30 commits July 13, 2021 18:13
@JoannaCoPo
Fix test typos; test passing
41ba7f1
@JoannaCoPo
Improve naming
f98cfad
@JoannaCoPo
Merge pull request #37 from Caleb1991/movie_details_refactor
b66726d 
Slight refactor on Movie poros, as well as APIServices
@JoannaCoPo
Merge refactor
dc1e6a6
@JoannaCoPo
Fix instance variable
2cf8c01
@JoannaCoPo
Fix routing for sessions login
cb87b24
@JoannaCoPo
Uncomment out show action
13360e5
@JoannaCoPo
Fix syntax issue
23301ca
@JoannaCoPo
Fix order syntax in top_rated
40dcd3d
@JoannaCoPo
Fix typo in index action
c38e1ef
@JoannaCoPo
Update text field specification
9a3fedb
@JoannaCoPo
Add spacing
2ce6b5d
@JoannaCoPo
Add line break
a740cfc
@JoannaCoPo
Create movies index spec
cd896ac
@JoannaCoPo
Debug tests
f35872e
@Caleb1991
Merge pull request #38 from Caleb1991/api_movie_search
4668426 
Api movie search
@Caleb1991
Update poros file, start work on new party
9e33845
@Caleb1991
Add some more functionality to new viewing party, currently incomplete
f7bc154
@Caleb1991
Merge branch 'main' into movie_details_refactor
2ebd2a8
@JoannaCoPo
Merge pull request #39 from Caleb1991/movie_details_refactor
bf76537 
Movie details refactor
@JoannaCoPo
Add logout functionality
ba919e5
@JoannaCoPo
Cleanup tests
96305c3
@Caleb1991
Merge pull request #40 from Caleb1991/jo_refactor
c482949 
Jo refactor
@Caleb1991
Minor refactors to make for better user experience, redirecting to us…
e07ee3e 
…ers dashboard upon creation rather than the root path
@Caleb1991
Merge pull request #41 from Caleb1991/minor_refactor
7aa0ff1 
Minor refactors to make for better user experience, redirecting to us…
@JoannaCoPo
Vcr setup
7582bff
@JoannaCoPo
Add a few tests for facade
2b9f279
@JoannaCoPo
Include setup for webmock attempt
dc2b3a5
@JoannaCoPo
Include setup for webmock attempt
bce0f23
@JoannaCoPo
Final test refactor
cfbb4db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoannaCoPo @Caleb1991