Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature_testing lesson for config change #340

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

juliet-e
Copy link
Contributor

Backend Curriculum PR Template

Description

Adds section in the feature testing class to describe the configuration change introduced by Rails 7.1.

Why are we making this update?

Students last inning were confused by the difference in exceptions they got from Set List vs. Relational Rails. Set List throws the errors because it was created with Rails 7.0 first so the config is still allowing louder failures. (We might just want to update Setlist to better reflect what it would look like in their Relational Rails project)

Type of update

  • Minor update/fix -- no review requested --- But would love eyes!!
  • Moderate update -- review from Mod Team requested
  • Major update -- review from Backend Team requested

How will we measure the success of this change?

No questions from students about why their errors depart from what they've seen in class

What questions do you have/what do you want feedback on? (optional)

@abdulredd
Copy link
Contributor

[Just adding my messages from Slack]

This is great, thanks Juliet!

As far as SetList, were you imagining updating all the branches of SetList excluding the one for the feature testing class? I ask because I’m not sure how I feel about completely handling this for them and then having them face the issue in the future and not know what the fix is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants