Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Company Model #123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/Company Model #123

wants to merge 2 commits into from

Conversation

Crosswolfv1
Copy link
Collaborator

@Crosswolfv1 Crosswolfv1 commented Feb 10, 2025 •
edited
Loading

Type of Change

  • bug fix 🐛

Description

Company Model: notes validation was set to allow NIL, post from FE has notes as blank when no content, changed validator to allow blank

Motivation and Context

#120
Users were unable to save companies w/o notes being present

Related Tickets

#120

Screenshots (if appropriate):

Added Test?

  • Yes 🫡
  • No 🙅
  • All previous tests still pass 🥳

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • This PR includes a Migration and I have notified the deployment team and PM so they can run the migration after the PR is merged.

@Crosswolfv1 Crosswolfv1 linked an issue Feb 10, 2025 that may be closed by this pull request
Bug - Add new company functionality not working on deployed site #120
Open
@Crosswolfv1 Crosswolfv1 changed the title Fix/Company Model: Notes was set to allow NIL, but data is coming in … Fix/Company Model Feb 10, 2025
TDManning
TDManning approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@TDManning TDManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to fix contact creation and update company notes validation to allow blank values. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDManning TDManning TDManning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - Add new company functionality not working on deployed site
2 participants
@Crosswolfv1 @TDManning