Skip to content

Commit

Permalink
removed eta
Browse files Browse the repository at this point in the history
  • Loading branch information
turingtest37 committed Sep 22, 2020
1 parent a16b76e commit 6a7f0ab
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 13 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ You may get **WARN**INGs upon compilation. You can safely ignore them for most p
[...]
```
The Sequencer also calculates a fitness coefficient `η` (`\eta`+`TAB` at the REPL) that can be used to compare quality of solutions using various metrics and scales against the same data. Bigger is better. η is also called `elongation` in SequencerJ. The accessor is `elong`.
The Sequencer also calculates a fitness coefficient `η` that can be used to compare quality of solutions using various metrics and scales against the same data. Bigger is better. η is returned by the `elong` function.
```julia
julia> eta = elong(seqres)
6.2345
Expand Down
1 change: 0 additions & 1 deletion docs/src/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ elong
order
mst
D
η
EMD()
EMD(u::AbstractVector{T}, v::AbstractVector{T}) where {T <: Real}
Expand Down
2 changes: 1 addition & 1 deletion src/SequencerJ.jl
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ include("distancemetrics.jl")
include("sequencer.jl")

# functions
export sequence, autoscale, D, mst, elong, η, elongation, order, prettyp, loss, ensuregrid!
export sequence, autoscale, D, mst, elong, elongation, order, prettyp, loss, ensuregrid!
export emd, energy

# types
Expand Down
9 changes: 0 additions & 9 deletions src/sequencer.jl
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,6 @@ struct SequencerResult
order::AbstractVector #final ordering from bfs
end

"""
η(r::SequencerResult)
Alias for `elong`, returns the final graph elongation of a Sequencer run. (Greek letter `eta`)
"""
η(r::SequencerResult) = elong(r)

"""
D(r::SequencerResult)
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ using Images

@testset "Accessor functions" begin
seqres = sequence(SMALL; scales=(2,), metrics=(L2,))
for f in (:elong, :order, :D, :mst, )
for f in (:elong, :order, :D, :mst)
@testset "$f" begin
@eval @test $f($seqres) !==nothing
end
Expand Down

2 comments on commit 6a7f0ab

@turingtest37
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/22110

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.0.0 -m "<description of version>" 6a7f0ab19075d05d279692ecfcc23b4f0e5e613d
git push origin v1.0.0

Please sign in to comment.