Add missing cause when throwing exceptions

turms-im · Dec 21, 2024 · dcd1716 · dcd1716
1 parent 4ad3b00
commit dcd1716
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 10 deletions.
diff --git a/turms-gateway/src/main/java/im/turms/gateway/domain/session/manager/HeartbeatManager.java b/turms-gateway/src/main/java/im/turms/gateway/domain/session/manager/HeartbeatManager.java
@@ -236,7 +236,8 @@ private Long closeOrUpdateSession(UserSession session, long nowNanos) {
                             t -> LOGGER.error(
                                     "Caught an error while closing the local user session ({}) with the close reason: {}",
                                     session,
-                                    HEARTBEAT_TIMEOUT));
+                                    HEARTBEAT_TIMEOUT,
+                                    t));
             return null;
         }
         session.setLastHeartbeatUpdateTimestampNanos(nowNanos);

diff --git a/...s-plugins/turms-plugin-push/src/main/java/im/turms/plugin/push/core/smtp/SmtpSession.java b/...s-plugins/turms-plugin-push/src/main/java/im/turms/plugin/push/core/smtp/SmtpSession.java
@@ -152,7 +152,7 @@ private static Mono<Void> onConnected(
         session.establish(ehloHostname, username, password, accessToken, startTls)
                 .subscribe(null, t -> {
                     LOGGER.error("Failed to establish the SMTP session: "
-                            + session.id);
+                            + session.id, t);
                     session.onClose(connectSink, t);
                 }, () -> {
                     LOGGER.info("Established the SMTP session: "

diff --git a/...r-common/src/main/java/im/turms/server/common/access/admin/web/HttpRequestDispatcher.java b/...r-common/src/main/java/im/turms/server/common/access/admin/web/HttpRequestDispatcher.java
@@ -249,7 +249,8 @@ private void notifyEndpointChangeListeners(Map<ApiEndpointKey, ApiEndpoint> keyT
             } catch (Exception e) {
                 LOGGER.error("Caught an error while notifying the endpoint change listener: "
                         + listener.getClass()
-                                .getName());
+                                .getName(),
+                        e);
             }
         }
     }

diff --git a/turms-server-common/src/main/java/im/turms/server/common/infra/client/TurmsTcpClient.java b/turms-server-common/src/main/java/im/turms/server/common/infra/client/TurmsTcpClient.java
@@ -148,7 +148,7 @@ public Mono<TurmsNotification> sendRequest(TurmsRequest.Builder requestBuilder)
     @Override
     public Mono<TurmsNotification> sendRequest(TurmsRequest request) {
         if (connection == null) {
-            return Mono.error(new IllegalStateException("The connection has not established"));
+            return Mono.error(new IllegalStateException("The connection has not been established"));
         }
         if (connection.isDisposed()) {
             return Mono.error(new IllegalStateException("The connection has been closed"));

diff --git a/...ver-common/src/main/java/im/turms/server/common/infra/cluster/service/rpc/RpcService.java b/...ver-common/src/main/java/im/turms/server/common/infra/cluster/service/rpc/RpcService.java
@@ -566,7 +566,7 @@ private <T> Mono<Map<String, T>> requestResponsesAsMap(
                         .isActive()) {
             return Mono.error(RpcException.get(RpcErrorCode.CONNECTION_NOT_FOUND,
                     ResponseStatusCode.SERVER_UNAVAILABLE,
-                    "Some connections have not established"));
+                    "Some connections have not been established"));
         }
         return Mono.deferContextual(context -> {
             addTraceIdToRequestFromContext(context, request);

diff --git a/...ain/java/im/turms/server/common/infra/logging/core/appender/file/RollingFileAppender.java b/...ain/java/im/turms/server/common/infra/logging/core/appender/file/RollingFileAppender.java
@@ -468,15 +468,15 @@ private void deleteLogFile(LogFile file) {
         try {
             Files.deleteIfExists(path);
         } catch (Exception e) {
-            InternalLogger.INSTANCE.error("Caught an error while delete the log file: "
-                    + path);
+            InternalLogger.INSTANCE.error("Caught an error while deleting the log file: "
+                    + path, e);
         }
         if (archivePath != null) {
             try {
                 Files.deleteIfExists(archivePath);
             } catch (Exception e) {
-                InternalLogger.INSTANCE.error("Caught an error while delete the log file: "
-                        + archivePath);
+                InternalLogger.INSTANCE.error("Caught an error while deleting the log file: "
+                        + archivePath, e);
             }
         }
     }

diff --git a/turms-server-common/src/main/java/im/turms/server/common/infra/plugin/PluginManager.java b/turms-server-common/src/main/java/im/turms/server/common/infra/plugin/PluginManager.java
@@ -338,7 +338,8 @@ private Mono<Void> loadNetworkPlugin(HttpClient client, NetworkPluginProperties
         } catch (Exception e) {
             return Mono.error(new IllegalArgumentException(
                     "Invalid plugin URL: "
-                            + url));
+                            + url,
+                    e));
         }
         String fileName = Paths.get(uri.getPath())
                 .getFileName()