Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Azure
It's probably worth noting the bt-vhd and vhd-bundle scripts are copied from
the vm counterparts so there is most likely unnecessary code left over.
Microsoft Azure only supports fixed vhds (vpc) aligned to 1MB. Using
"qemu-img info" and "qemu-img resize" this is trivial. First resize the image
to the next largest 1MB and then convert the raw image to a vpc fixed sized
image and pass "force_size" to assure the image is not padded during
conversion.
"qemu-img convert -o subformat=fixed,force_size ..."
Note a bug in qemu preventing it from maintaining image size between vhd
conversions has been fixed in qemu 2.6. Qemu will need to be updated to convert
raw to azure compatible vhds.
Waagent was running correctly previously however since my most recent commit it
isn't polluting the root console of the vm nor is the vm saying the agent is
running. While I'm not 100% sure I suspect this is because I was previously
(accidently) running the azure patch twice, once directly from the bt-vhd
script and one from within bin/vhd-bundle, during cleaning up I removed the
call from bt-vhd.
Other notes
Waagent seems to handle ssh/user accounts on Azure, although I'm unsure of
how it works as I was never able to login to any of my test machines on
Azure.
A few grub options are added to GRUB_DEFAULT, I was unsure of their effect
and not knowing possible implications either way decided to follow MS's
advice.
Azure doesn't support LVM, so LVM is not present azure build code
Waagent pollutes the TKLDev's root console as well as changes it's hostname,
nothing destructive that I've noticed though.
The ethernet interfaces should probably be hotpluggable by default
The azure cli appears to either auto-update or retrieve avaliable commands
from microsoft, as I've noticed command names change.