Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was initially and primarily a practical experiment with
click
- which is an alternative cli argument parsing library. In the case of Pool, I'm replacingargparse
(which in previously turn replacedoptparse
).But there were still a few typing issues, so I fixed them first. Then after implementing the click stuff, in the interests of organization and readability, it seemed splitting out the non-core cli functions into separate files (in
pool_lib
) was a good idea.Overview of massive refactoring:
click
to manage cli options (replacesargparse
)pool_bin
->pool
pool_info.py
utils.py
extras.py
(not sure what these are for, perhapsbuild-info
?)Whilst this code looks ok and passes typing checks (pyright) and style linting (pycodestyle), at this stage it is completely untested...