Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click for kicks #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JedMeister
Copy link
Member

@JedMeister JedMeister commented Jan 7, 2024

This was initially and primarily a practical experiment with click - which is an alternative cli argument parsing library. In the case of Pool, I'm replacing argparse (which in previously turn replaced optparse).

But there were still a few typing issues, so I fixed them first. Then after implementing the click stuff, in the interests of organization and readability, it seemed splitting out the non-core cli functions into separate files (in pool_lib) was a good idea.

Overview of massive refactoring:

  • finish/fix typing
  • implementation of click to manage cli options (replaces argparse)
  • refactor/reorganize code - new files/paths:
    • rename pool_bin -> pool
    • move pool info functions to pool_info.py
    • move general functions to utils.py
    • move remaining non cli arg related func(s) to extras.py (not sure what these are for, perhaps build-info?)

Whilst this code looks ok and passes typing checks (pyright) and style linting (pycodestyle), at this stage it is completely untested...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant