Py version bump, convert to pyproject.toml setup and general cleanup #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the subject, this PR bumps the python version (to
>= 3.11), converts the project from usingsetup.pytopyproject.toml, and updates to the python code (typing tweaks and updates, linting and general cleanup).No rush to merge this as we won't really need it until we get to 13/Trixe base (i.e. v19.x).
FYI my main motivation to do this is to get a handle on how the process of moving from
setup.pyto the more modernpyproject.tomlconfig for building the package. Hopefully this will be able to serve as an example for updating other turnkey packages. The other stuff was mostly just tidying.The only change that may be somewhat controversial is my replacement of
Unionwith|. IMO it's cleaner and easier reading (use of '|' requires python v3.10+).