Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Go version to 1.20 #93

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Downgrade Go version to 1.20 #93

merged 2 commits into from
Dec 15, 2023

Conversation

avinassh
Copy link
Member

Goose is a pretty slick migration tool and I am trying to add Turso support to it. I have opened a PR here - pressly/goose#658

However, goose minimum go version requirement is 1.19 and maintainers do not want to increase it to 1.21 just for Turso, which is reasonable. But they are fine merging if the version is 1.20.

In our library, we only use slice.Contains function, so I have back ported those and reduced the min version to 1.20

@avinassh avinassh requested a review from haaawk December 15, 2023 14:25
@avinassh avinassh merged commit bc1f2dc into main Dec 15, 2023
2 checks passed
@avinassh avinassh deleted the go1.19 branch December 15, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants