Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add git+ prefix to repo url in package.json #265

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

alcpereira
Copy link
Contributor

While investigating tsup as a solution, I first checked if the libraries were correctly published by using:

I noticed a small issue with the rule INVALID_RESOSITORY_VALUE.

This PR aims to fix it.

Copy link
Member

@notrab notrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🚀 This could be simplified to use the short hand "repository": "tursodatabase/libsql-client-ts" too, which is used in some other packages of Turso's.

@alcpereira
Copy link
Contributor Author

Lgtm 🚀 This could be simplified to use the short hand "repository": "tursodatabase/libsql-client-ts" too, which is used in some other packages of Turso's.

TIL! Do you want me to update to the simplified one?

@notrab
Copy link
Member

notrab commented Nov 1, 2024

@alcpereira Sure! I'll merge this right away with that change.

@alcpereira
Copy link
Contributor Author

I checked the docs and other popular libraries, it seems that it's more common to use the longer version.
An improvement to the current suggested changes would be to include the directory property that is preferable for monorepos (that will also invalidate the possibility of having a shorter version).

@alcpereira alcpereira force-pushed the chore/update-git-urls branch from 92c3848 to cea871e Compare November 1, 2024 11:15
@notrab notrab merged commit 1e77794 into tursodatabase:main Nov 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants