This repository has been archived by the owner on Aug 10, 2023. It is now read-only.
Jitsi widget supports audio mute manipulation #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
changed the title
|
Yeah, give me a little bit while I add more to this. |
anoadragon453
changed the title
anoadragon453
changed the title
anoadragon453
commented
Nov 4, 2018
turt2live
approved these changes
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of my push-to-talk work and handling element-hq/element-web#5993, adds an API to handle Jitsi audio toggle requests from Riot.
Eventually this will hopefully get an upgrade to allow for audio "mute" and "unmute" commands, but some other factors are blocking that at the moment, plus Jitsi's iframe API only allows for toggling, so some logic will be needed to determine the current state of the audio before determining if toggling is necessary.
Edit: The logic was added