improved error handling to alert user that sci connection issues can … #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be caused by wrong baud rate or wrong robot base type.
…int not found errors.
|
I'm lost with the Create vs Create 2 vs Roomba part, as I have never used a create. |
…TURTLEBOT_BASE=create for Create 1 base, TURTLEBOT_BASE=roomba for Create 2.
|
Some more background in case it helps: I believe there was no "create 2" when this code was originally written, there was the Create 1 and a Roomba. The create 2 is a refurbished Roomba w/ the vacuum parts removed, which is why a Create 2 only works with TURTLEBOT_BASE=roomba. Someone who does not know the difference between a Create 1 or a Create 2 will put TURTLEBOT_BASE=create and their bot will not connect. This error message can help them see they should try "roomba" for Create 2. I will make a suggestion to update on the wiki tutorial also which will alleviate this problem too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improved error handling to alert user that sci connection issues can be caused by wrong baud rate or wrong robot base type. Users typically get a "check your cable" error and no other info. Often times the wrong robot type is causing a baudrate mismatch. For example, someone with a Create 2 using the "create" robot type will use 57600 baud rate when they should be using 115200 of the roomba.