Move all database queries off the ui thread & add a ViewModel for MainActivity #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
connyduck
commented
Dec 3, 2024
•
connyduck
commented
- Move all database queries off the ui thread - this is a massive performance improvement
- ViewModel for MainActivity - this makes MainActivity smaller and network requests won't be retried when rotating the screen
- removes the Push Notification Migration feature. We had it long enough, all users who want push notifications should be migrated by now
- AccountEntity is now immutable
- The header image of Accounts is now cached as well
# Conflicts: # app/src/main/java/com/keylesspalace/tusky/MainActivity.kt # app/src/main/java/com/keylesspalace/tusky/components/login/LoginActivity.kt
# Conflicts: # app/src/main/java/com/keylesspalace/tusky/components/preference/AccountPreferencesFragment.kt
connyduck
commented
Dec 11, 2024
| @@ -46,7 +46,6 @@ object StorageModule { | |||
| fun providesDatabase(@ApplicationContext appContext: Context, converters: Converters): AppDatabase { | |||
| return Room.databaseBuilder(appContext, AppDatabase::class.java, "tuskyDB") | |||
| .addTypeConverter(converters) | |||
| .allowMainThreadQueries() | |||
# Conflicts: # app/src/main/java/com/keylesspalace/tusky/MainActivity.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.