Show new event button in Agenda view when it's empty (for single and two columns layout) #7143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrehgdias
force-pushed
the
7139-new-event-button-at-the-agenda-view
branch
3 times, most recently
from
00cd332
to
023aa4e
Compare
andrehgdias
force-pushed
the
7139-new-event-button-at-the-agenda-view
branch
2 times, most recently
from
dcf2a1c
to
6f4e46d
Compare
2 tasks
src/gui/base/buttons/BaseButton.ts
Outdated
| @@ -61,3 +64,20 @@ export class BaseButton implements ClassComponent<BaseButtonAttrs> { | |||
| function booleanToAttributeValue(value: boolean | null | undefined): string | null { | |||
| return value != null ? String(value) : null | |||
| } | |||
|
|
|||
| export function renderNewEventButton(buttonAttrs: { label: TranslationKey; click: ClickHandler; style?: Record<string, any> }): Children { | |||
There was a problem hiding this comment.
The name should be more generic in this case since this button is also used to create a new email.
src/gui/base/buttons/BaseButton.ts
Outdated
| @@ -61,3 +64,20 @@ export class BaseButton implements ClassComponent<BaseButtonAttrs> { | |||
| function booleanToAttributeValue(value: boolean | null | undefined): string | null { | |||
| return value != null ? String(value) : null | |||
| } | |||
|
|
|||
| export function renderNewEventButton(buttonAttrs: { label: TranslationKey; click: ClickHandler; style?: Record<string, any> }): Children { | |||
There was a problem hiding this comment.
This isn't a base button, it's worthwhile to have it's own file
murilopereirame
requested changes
Jul 9, 2024
| label: "newEvent_action", | ||
| click: () => attrs.onCreateEvent?.(), | ||
| style: { | ||
| "margin-top": ".6rem", |
There was a problem hiding this comment.
We have some utility classes for sizing and margins that we should use to keep the spacing standardized, take a look at main-styles.ts#L266
andrehgdias
force-pushed
the
7139-new-event-button-at-the-agenda-view
branch
2 times, most recently
from
7c8d073
to
2469943
Compare
andrehgdias
changed the base branch from
dev-calendar
to
7147-update-settings-for-standalone-calendar-app
andrehgdias
changed the base branch from
7147-update-settings-for-standalone-calendar-app
to
dev-calendar
andrehgdias
force-pushed
the
7139-new-event-button-at-the-agenda-view
branch
from
2469943
to
0b908e7
Compare
murilopereirame
approved these changes
Jul 10, 2024
wrdhub
approved these changes
Jul 11, 2024
rih-tutao
approved these changes
Jul 12, 2024
andrehgdias
force-pushed
the
7139-new-event-button-at-the-agenda-view
branch
from
0b908e7
to
e3259b4
Compare
andrehgdias
force-pushed
the
7139-new-event-button-at-the-agenda-view
branch
from
e3259b4
to
24f5c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7139
