support npm #13
Open
support npm #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now use $("selector:in-viewport(300)")
Webkit has the behavior to display a number. For example. in webkit you divide the screen size by 3. and use this percentage for the css left property. This library returns for the offset().left a 0.33xxxx which has to be 0 or 1.
Conflicts: jquery.viewport.js
Conflicts: jquery.viewport.js
Added package.json for npm.
|
@tuupola is this repo no longer supported? |
|
Kind of forgotten. But I can actually cherry-pick the good commits from this PR. So let's keep this open. |
|
@1337 now owns the package on NPM so you'll need to get that too |
add UMD loader
|
What am I doing here? |
|
@1337 you own the package on NPM right? |
|
Yup |
|
Are you going to do a release for this project? |
|
Apart from these (from a fork), what release are we looking for? |
|
I'm sorry, I meant a release of the tuupola master branch |
|
Yeah, I just cherry pick the good parts from this PR first. |
|
@tuupola that's not really the best idea as that will change a lot of the history. |
|
PR is supposed to be about supporting npm but contains lots of unrelated commits. There are some good things in them, hence the cherry-picking. |
jQuery 3 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.