fix build error on Ubuntu 16.04 #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tux3
reviewed
Feb 15, 2017
| @@ -9,7 +9,8 @@ | |||
| #include <QPen> | |||
| #include <QPainter> | |||
| #include <QRgb> | |||
| #include <QtConcurrent/QtConcurrent> | |||
| #include <QtConcurrentRun> | |||
There was a problem hiding this comment.
This doesn't build for me using a freshly downloaded Qt 5.8 SDK on Linux, I have that header in QtConcurrent/QtConcurrentRun instead
What version of Qt are you compiling with?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bunch of build errors on Ubuntu 16.04. I've fixed them, but did not test if the fixes break anything on Windows.
Short summary:
QtConcurrentheader. It is not present on Ubuntu.c++11configuration not being readtakeAtmethod available. Replaced with genericatmethod. In case you don't need to check the boundaries, one can replace it with[index].