-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GCC and Clang GitHub workflow builds #6
base: edge
Are you sure you want to change the base?
Conversation
This enables CI on the GitHub repository.
An example of GitHub Actions build (for this Pull Request) can be found at: https://github.com/pbatard/ntfs-3g/actions/runs/1053111129 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly this is a github-specific file that if present in the repository would enable a "build-check" to be triggered for each push to the repository?
Can you describe the benefits in more detail... we have such automated checks running already on Tuxera's servers so I'm not sure how useful it would be to use github's resources for the same purpose.
Thanks for looking into this PR. The benefits are that, even if you do have your own internal test, anybody who clones the directory and performs some work would have a GCC + Clang build check performed for each commit they apply to their repo. So, in essence, rather than keep the internal Tuxera build test for yourself, you can, in a simple PR, provide such a build test to the community that depends on your work. This also would mean that anybody who provides a GitHub Pull Request would get a build test performed automatically, which avoids a lot of the usual back and forth of finding that a commit is broke builds for a simple overlooked detail and extra work for you for having to perform such test. In other words, one advantage of this is to make sure that, when users submit patches through PRs, you would instantly be able to eliminate the following process:
Plus, at no cost for anyone (except GitHub, really), it does makes at least some of the modern methods of validating software, such as Continuous Integration testing, public, which, for an Open Source project such as ntfs-3g that is depended on by a large number of people, should be seen as a "good thing"™. There are also quite a few other benefits that I could list, such as, if the Tuxera CI process is not based on the latest Ubuntu as opposed to this one ( |
@jpandre: Have you seen this PR? |
Now that ntfs-3g is hosted on GitHub, we can enable CI on the GitHub repository for both commits and pull requests.