Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Modernize ember-simple-pagination Addon #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vstefanovic97
Copy link

This Addon needed some love so I did a full refactor, it would be nice if we could get this merged and have a Major release

Work done

  • Converted the simple-pagination component to glimmer
  • Converted the Addon to v2 addon format (Upgrading all deps along the way)
  • Updated the docs with angle bracket invocation and modern usage example

Breaking changes

  • Drops all Node versions below 14
  • Drops all Ember versions below 3.24
  • dataTestSelector is no longer accepted as an argument on simple-pagination component (it should be provided as an attribute as not we have ...attributes on the containing div)

Important notes

  • Updated ember-try to target correct ember versions above >= 3.24
  • Deleted Unit tests as invoking component in that way is no longer supported (I think we should be good with the coverage we have in integration tests)
  • Changed the version in package.json to 2.0.0 to signal breaking change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant