This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Addon needed some love so I did a full refactor, it would be nice if we could get this merged and have a Major release
Work done
simple-pagination
component to glimmerBreaking changes
dataTestSelector
is no longer accepted as an argument onsimple-pagination
component (it should be provided as an attribute as not we have...attributes
on the containing div)Important notes
ember-try
to target correct ember versions above >= 3.24package.json
to2.0.0
to signal breaking change