Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular Includes #1016

Closed
wants to merge 1 commit into from
Closed

Granular Includes #1016

wants to merge 1 commit into from

Conversation

robertmain
Copy link

Use globs instead of explicit top level file names. This makes it possible to only include specific SCSS files in applications that use this library

Use globs instead of explicit top level file names. This makes it possible to only include specific SCSS files in applications that use this library
@cvrebert
Copy link
Collaborator

Globs in main are explicitly disallowed by the bower.json specification; see https://github.com/bower/spec/blob/master/json.md#main

@cvrebert cvrebert closed this Feb 12, 2016
@robertmain
Copy link
Author

In that case perhaps you would consider a version that enumerated each sass file so that those of us using gulp don't have to have the entirety of bootstrap pulled in

@cvrebert
Copy link
Collaborator

That wouldn't be a valid main value either, per the spec ("Only one file per filetype.").
Personally, I advise against using Bower, due to these sorts of issues and the Bower project's general lack of progress in addressing them. Using npm instead is usually a viable option these days.
Otherwise, you can lobby for bower/spec#47 and/or set an appropriate overrides entry for Bootstrap in your project's bower.json

@cvrebert
Copy link
Collaborator

Or perhaps the gulp task you're using was written with incorrect assumptions about main and is thus buggy.

@robertmain
Copy link
Author

I'll just keep my fork open then
On 12 Feb 2016 4:56 pm, "Chris Rebert" [email protected] wrote:

That wouldn't be a valid main value either, per the spec ("Only one file
per filetype.").
Personally, I advise against using Bower, due to these sorts of issues and
the Bower project's general lack of progress in addressing them. Using npm
instead is usually a viable option these days.
Otherwise, you can lobby for bower/spec#47
bower/spec#47 and/or set an appropriate
overrides entry for Bootstrap in your project's bower.json


Reply to this email directly or view it on GitHub
#1016 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants