Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icons-font example with workspaces #155

Closed
wants to merge 1 commit into from

Conversation

kyletsang
Copy link
Contributor

In relation to #114 (comment)

Something like this @XhmikosR?

@XhmikosR
Copy link
Member

XhmikosR commented Apr 1, 2023

I tried your branch on StackBlitz but it doesn't seem to work either :/

https://stackblitz.com/github/kyletsang/examples/tree/workspaces-icons/packages/icons-font?file=index.html

Not against such a solution yet, thanks for looking into it!

@kyletsang
Copy link
Contributor Author

Oops forgot to check if this worked on StackBlitz. Not sure of a clean way to do this 😞

@XhmikosR
Copy link
Member

XhmikosR commented Apr 2, 2023

No worries! I guess I'll drop the workspaces experiment for the time being :/

@XhmikosR XhmikosR closed this Apr 2, 2023
@XhmikosR XhmikosR mentioned this pull request Apr 2, 2023
4 tasks
@kyletsang kyletsang deleted the workspaces-icons branch April 2, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants