Skip to content

Commit

Permalink
Merge pull request #233 from wmundev/feature/replace-old-link
Browse files Browse the repository at this point in the history
docs: update outdated links and use markdown format for readme
  • Loading branch information
twcclegg authored Feb 23, 2024
2 parents 0c73c9f + 41ade85 commit 5fba9a6
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 37 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ The code was rewritten from the Java source mostly unchanged, please refer to th

The original Apache License 2.0 was preserved.

See [this](https://github.com/twcclegg/libphonenumber-csharp/blob/main/csharp/README.txt "csharp/README.txt") for details about the port.
See [this](csharp/README.md) for details about the port.

Phone number metadata is updated in the Google repo approximately every two weeks. This library is automatically updated by a [scheduled github action](https://github.com/twcclegg/libphonenumber-csharp/actions/workflows/create_new_release_on_new_metadata_update.yml) to include the latest metadata, usually within a day.

Expand Down
5 changes: 2 additions & 3 deletions csharp/PhoneNumbers.Test/TestAsYouTypeFormatter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ public void TestInvalidPlusSign()
[Fact]
public void TestTooLongNumberMatchingMultipleLeadingDigits()
{
// See http://code.google.com/p/libphonenumber/issues/detail?id=36
// This occurred last time for countries which have two formatting rules with exactly the
// See https://github.com/google/libphonenumber/issues/36
// The bug occurred last time for countries which have two formatting rules with exactly the
// same leading digits pattern but differ in length.
var formatter = phoneUtil.GetAsYouTypeFormatter("ZZ");
Assert.Equal("+", formatter.InputDigit('+'));
Expand All @@ -104,7 +104,6 @@ public void TestTooLongNumberMatchingMultipleLeadingDigits()
Assert.Equal("+819012345678901", formatter.InputDigit('1'));
}


[Fact]
public void TestAYTFUS()
{
Expand Down
2 changes: 1 addition & 1 deletion csharp/PhoneNumbers/PhoneNumbers.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Description>C# port of Google's common Java, C++ and Javascript library for parsing, formatting, storing and validating international phone numbers. http://code.google.com/p/libphonenumber/</Description>
<Description>C# port of Google's common Java, C++ and Javascript library for parsing, formatting, storing and validating international phone numbers. https://github.com/google/libphonenumber</Description>
<Title>libphonenumber-csharp</Title>
<AssemblyName>PhoneNumbers</AssemblyName>
<PackageId>libphonenumber-csharp</PackageId>
Expand Down
64 changes: 32 additions & 32 deletions csharp/README.txt → csharp/README.md
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
PhoneNumbers C# Library
=======================
This is a C# port of libphonenumber, originally from:
http://code.google.com/p/libphonenumber/.
Original Java code is Copyright (C) 2009-2022 Google Inc.
lib/
update script
PhoneNumbers/
Port of libphonenumber Java library
PhoneNumbers.Test/
Port of libphonenumber Java tests in xunit format.
Known Issues
------------
- Phone numbers metadata is read from XML files and not protocol
buffers one. I could not make it work using protobuf-csharp
library. On the other hand, it makes one less dependency.
Todo
----
- Restore the Java logging calls?
- Find a suitable replace for Java CharSequence in phone numbers parsing API.
- Migrate geocoder and related files
PhoneNumbers C# Library
=======================

This is a C# port of libphonenumber, originally from:
https://github.com/google/libphonenumber

Original Java code is Copyright (C) 2009-2022 Google Inc.

`lib/`
update script

`PhoneNumbers/`
Port of libphonenumber Java library

`PhoneNumbers.Test/`
Port of libphonenumber Java tests in xunit format.


Known Issues
------------

- Phone numbers metadata is read from XML files and not protocol
buffers one. I could not make it work using protobuf-csharp
library. On the other hand, it makes one less dependency.


Todo
----

- Restore the Java logging calls?
- Find a suitable replace for Java CharSequence in phone numbers parsing API.
- Migrate geocoder and related files

0 comments on commit 5fba9a6

Please sign in to comment.