xml style comments for PhoneNumberUtil #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eNumberUtil, and set project to generate xml help file. The comments should now show up in intellisense. There's an issue with enabling XML documentation file in the project options where it set's an absolute file path. The recommendation form https://developercommunity.visualstudio.com/content/problem/319886/default-xml-documentation-file-path-is-absolute.html was to set GenerateDocumentationFile to true in the project.
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 26 26
Lines 3201 3201
=======================================
Hits 2964 2964
Misses 237 237
Continue to review full report at Codecov.
|
|
Thanks! Is this something you did by hand or were do you have a tool that does it? A step to addressing #60 |
|
I did it by hand. I don't know of a tool to automate conversion of the comments :(. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed some javadoc style comments to c# xml style comments for PhoneNumberUtil, and set project to generate xml help file. The comments should now show up in intellisense. There's an issue with enabling XML documentation file in the project options where it set's an absolute file path. The recommendation form https://developercommunity.visualstudio.com/content/problem/319886/default-xml-documentation-file-path-is-absolute.html was to set GenerateDocumentationFile to true in the project.