New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed `Debug` impl of `EvalOrDeserError` printing entire source of files #2118

Merged

yannham merged 1 commit into tweag:master from rben01:debug-EvalOrDeserError

Dec 2, 2024

+19 −1

Contributor

rben01 commented Dec 2, 2024

Now it just prints filenames, which is much more useful.


          Fixed Debug impl of EvalOrDeserError printing entire source of files

3ecea43

Now it just prints filenames

Contributor

github-actions bot commented Dec 2, 2024

Bencher Report

Branch	debug-EvalOrDeserError
Testbed	ubuntu-latest

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
fibonacci 10	📈 view plot 🚷 view threshold	485,570.00
foldl arrays 50	📈 view plot 🚷 view threshold	1,681,000.00
foldl arrays 500	📈 view plot 🚷 view threshold	6,782,800.00
foldr strings 50	📈 view plot 🚷 view threshold	7,233,700.00
foldr strings 500	📈 view plot 🚷 view threshold	62,810,000.00
generate normal 250	📈 view plot 🚷 view threshold	42,791,000.00
generate normal 50	📈 view plot 🚷 view threshold	2,040,600.00
generate normal unchecked 1000	📈 view plot 🚷 view threshold	3,394,500.00
generate normal unchecked 200	📈 view plot 🚷 view threshold	783,510.00
pidigits 100	📈 view plot 🚷 view threshold	3,167,000.00
pipe normal 20	📈 view plot 🚷 view threshold	1,501,500.00
pipe normal 200	📈 view plot 🚷 view threshold	10,178,000.00
product 30	📈 view plot 🚷 view threshold	821,250.00
scalar 10	📈 view plot 🚷 view threshold	1,490,200.00
sum 30	📈 view plot 🚷 view threshold	818,760.00

🐰 View full continuous benchmarking report in Bencher

yannham approved these changes

View reviewed changes

Member

yannham left a comment

Thanks! The CI is failing for reason unrelated to this PR; this is being addressed in parallel. Might need a rebase then.

yannham added this pull request to the merge queue

Merged via the queue into tweag:master with commit 0d93c67

4 of 5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet