Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ok -> ok #70

Closed

Conversation

infinisil
Copy link
Member

No description provided.

@infinisil infinisil force-pushed the check-by-name-base-test branch from 124d15c to 84f162a Compare October 2, 2023 18:35
@infinisil infinisil force-pushed the check-by-name-base-test-ok-ok branch from 7d20c3d to 7f045d0 Compare October 2, 2023 18:35
@infinisil infinisil force-pushed the check-by-name-base-test branch from 84f162a to 6f2c650 Compare October 2, 2023 18:37
@infinisil infinisil force-pushed the check-by-name-base-test-ok-ok branch from 7f045d0 to 57a7c5b Compare October 2, 2023 18:37
@infinisil infinisil force-pushed the check-by-name-base-test branch from 6f2c650 to b7e7b2d Compare October 2, 2023 19:19
@infinisil infinisil force-pushed the check-by-name-base-test-ok-ok branch from 57a7c5b to 1cd31d6 Compare October 2, 2023 19:20
@infinisil infinisil force-pushed the check-by-name-base-test branch from b7e7b2d to faed0ab Compare October 2, 2023 19:27
@infinisil infinisil force-pushed the check-by-name-base-test-ok-ok branch from 1cd31d6 to fd2ab4f Compare October 2, 2023 19:27
@infinisil infinisil force-pushed the check-by-name-base-test branch from faed0ab to a70f0d1 Compare October 2, 2023 19:48
Previously, even if the check also failed on the base branch, it looked
like the PR introduced the failure.

We can easily have a better error message for such cases.

Meanwhile this also paves the road for something like
NixOS#256788
@infinisil infinisil force-pushed the check-by-name-base-test branch from a70f0d1 to a487747 Compare October 2, 2023 19:51
@infinisil infinisil force-pushed the check-by-name-base-test-ok-ok branch from fd2ab4f to 8807975 Compare October 2, 2023 19:51
@infinisil infinisil force-pushed the check-by-name-base-test branch from a487747 to 6e5e814 Compare October 2, 2023 19:58
@infinisil infinisil closed this Oct 4, 2023
@infinisil infinisil deleted the check-by-name-base-test-ok-ok branch October 4, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant